On Mon, Feb 04, 2019 at 12:58:28PM -0800, Christoph Hellwig wrote: > > + next_ino = XFS_AGINO_TO_INO(mp, pag->pag_agno, next_agino); > > + error = xfs_iunlink_map_ino(tp, next_ino, imap, &last_dip, > > + &last_ibp); > > Last round I suggested pasing the agno/agino to xfs_iunlink_map_ino, > and good reason for not doing that? I forgot to do it. :( Looking through the code, I could also change the _update_dinode function to take xfs_agino_t instead of xfs_ino_t, though even that is nearly pointless since we only do it to feed a tracepoint. Anyway, I'll incorporate that into v3. --D
