On 12/19/18 1:30 PM, Darrick J. Wong wrote:
> From: Darrick J. Wong <darrick.wong@xxxxxxxxxx>
>
> In mk_root_dir, we reinitialize the root directory inode with a link
> count of 1. This differs from mkfs parseproto, which initializes the
> root to have a link count of 2. The nlink discrepancy in repair is
> caught and corrected during phase 7, but this is unnecessary since we
> should set it properly in the first place.
>
> Signed-off-by: Darrick J. Wong <darrick.wong@xxxxxxxxxx>
I have this nagging feeling that played whackamole with root dir counts
but can't find any real evidence of that now. Seems ok.
Reviewed-by: Eric Sandeen <sandeen@xxxxxxxxxx>
> ---
> repair/phase6.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>
> diff --git a/repair/phase6.c b/repair/phase6.c
> index 9477bc25..8a50b350 100644
> --- a/repair/phase6.c
> +++ b/repair/phase6.c
> @@ -891,7 +891,7 @@ mk_root_dir(xfs_mount_t *mp)
> ip->i_d.di_format = XFS_DINODE_FMT_EXTENTS;
> ip->i_d.di_aformat = XFS_DINODE_FMT_EXTENTS;
>
> - set_nlink(VFS_I(ip), 1); /* account for . */
> + set_nlink(VFS_I(ip), 2); /* account for . and .. */
>
> times = XFS_ICHGTIME_CHG | XFS_ICHGTIME_MOD;
> if (ip->i_d.di_version == 3) {
>
