On Sun, Jan 27, 2019 at 7:02 AM Eryu Guan <guaneryu@xxxxxxxxx> wrote: > > [I'm sorry that I've been absent from the discussion entirely.. I was > busy with other tasks recently.] > > On Thu, Jan 24, 2019 at 10:33:10AM +0200, Amir Goldstein wrote: > > This test has the number of files/dirs created by fsstress hardcoded > > in golden output. > > This leads me to wonder if we could remove the hardcoded dir/entries > number from the golden output and verify the counts on the fly? i.e. we > count the dir/entries numbers that fsstress created and compare them > with the numbers xfsrestore reports. So we don't have to worry about new > ops in fsstress and xfs configurations. > posted v2 with a slightly different approach: count the dir/entries numbers that fsstress created and compare them with the *actual* numbers xfsrestore created instead of the numbers that xfsrestore reports. Sure, this removes test coverage for the accuracy of the report, but that was really never the intention of the test and the report is really wrong! (off by one dir from actual restored). If someone really cares about validating the accuracy of xfsrestore report in that test, that by all means, let someone read into xfsrestore and figure out what the one directory stands for and either fix xfsrestore or work that quirk into the test. As can be inferred, that someone is not going to be me. Thanks, Amir.
