On Thu, Jan 17, 2019 at 08:41:48AM -0800, Christoph Hellwig wrote: > On Thu, Jan 17, 2019 at 11:35:17AM -0500, Brian Foster wrote: > > Hmm, it would be nice if these fixes were separate from the whole > > always_cow thing. Some initial thoughts on a quick look through the > > first few patches on the v3 post: > > We can always skip the last patch. It just helps to really nicely > show a lot of the problems that are otherwise hard to reproduce, but > already exist. > > FYI, I just resent it like a minute before reading your mail. > > > 1. It's probably best to drop your xfs_trim_extent_eof() changes as I > > have a stable patch to add a couple more calls and then I subsequently > > remove the whole thing going forward. Refactoring it is just churn at > > this point. > > Sure. > > > 2. The whole explicit race with truncate detection looks rather involved > > to me at first glance. I'm trying to avoid relying on i_size at all for > > this because it doesn't seem like a reliable approach. E.g., Dave > > described a hole punch vector for the same fundamental problem this > > series is trying to address: > > > > https://marc.info/?l=linux-xfs&m=154692641021480&w=2 > > > > I don't think looking at i_size really helps us with that, but I could > > be missing other changes in the cow series. > > The i_size detection isn't new in this series, just slightly moved > around. And it really is just intended as an optimization to not > even bother if we are beyond i_size. > Ok, then I probably need to take a closer look. The purpose of these patches are to remove it and replace it with something that fundamentally addresses the underlying problem (i.e., the fork change detection). > > > > In general I'm looking at putting something like this in > > xfs_iomap_write_allocate() once the data fork sequence number tracking > > is enabled: > > > > /* > > * Now that we have ILOCK we must account for the fact > > * that the fork (and thus our mapping) could have > > * changed while the inode was unlocked. If the fork > > * has changed, trim the caller's mapping to the > > * current extent in the fork. > > We don't even look at the callers mapping except for the range to > cover. And that is how e.g. direct I/O also works and a good thing > as far as I can tell. To make use of the previous mapping we'd have > to rewrite xfs_bmapi_write. > Yes, that's really just semantics. The purpose of the lookup in this context is to trim down the range to map. We can only guarantee the range specified by the current page once we cycle ilock, so we have to consider that any part of the range external to that has become invalid. This change to xfs_iomap_write_allocate() doesn't introduce any new way of using the caller's imap that isn't already done by the existing code. We just access the inode fork to validate the range rather than the inode size because the caller already gives us information to confirm whether the range has been invalidated (the *seq param) whereas the i_size could have been truncated down and up since the last time we checked it. > If we want to be able to reuse existing mapings I think the sequences > are helping us a bit, but a lot more work is needed, and it should > be done in a generic way and not just in this path. I'm assuming that a correct solution will lend itself to cleaning up much of this code to do things like reduce the need for validations, provide commonality with other paths, clean up layering, etc., but I'm not worrying about that until we're confident that this is a correct and viable approach. Brian
