From: Darrick J. Wong <darrick.wong@xxxxxxxxxx> In xrep_findroot_block, we work out the btree type and correctness of a given block by calling different btree verifiers on root block candidates. However, we leave the NULL b_ops while ->verify_read validates the block, which means that if the verifier calls xfs_buf_verifier_error it'll crash on the null b_ops. Fix it to avoid this crash. Signed-off-by: Darrick J. Wong <darrick.wong@xxxxxxxxxx> --- FWIW I also thought about stuffing in a fake b_ops while xrep_findroot is calling a candidate read verifier, but thought that might just confuse things more? --- fs/xfs/xfs_error.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/xfs/xfs_error.c b/fs/xfs/xfs_error.c index 9866f542e77b..2a02be280769 100644 --- a/fs/xfs/xfs_error.c +++ b/fs/xfs/xfs_error.c @@ -359,7 +359,7 @@ xfs_buf_verifier_error( xfs_alert(mp, "Metadata %s detected at %pS, %s block 0x%llx %s", bp->b_error == -EFSBADCRC ? "CRC error" : "corruption", - fa, bp->b_ops->name, bp->b_bn, name); + fa, bp->b_ops ? bp->b_ops->name : "unknown", bp->b_bn, name); xfs_alert(mp, "Unmount and run xfs_repair");
