On 1/14/19 11:42 AM, Stefan Ring wrote: > On Fri, Jan 11, 2019 at 6:31 PM Eric Sandeen <sandeen@xxxxxxxxxxx> wrote: >> >> On 1/7/19 2:13 PM, Stefan Ring wrote: >>> Using basically the same code as in process_single_fsb_objects. >>> >>> Signed-off-by: Stefan Ring <stefanrin@xxxxxxxxx> >> >> thanks, the change here to goto write: looks good to me. >> >> Reviewed-by: Eric Sandeen <sandeen@xxxxxxxxxx> > > Thanks, this makes my series fully reviewed. Is there anything left > for me to do now? FWIW, I added the Reviewed-by tag and pushed it to > <https://github.com/Ringdingcoder/xfsprogs-dev/commits/metadump-fully-reviewed>. > I don't think so. Pretty sure the failures I ran into with my extended xfstests harness are actually pre-existing, and Carlos is looking at the root cause. I'll give it another once-over but I hope/plan to include this in xfsprogs-4.20 now. Apologies for the long wait, I can't tell you how much I appreciate your effort on this. Thank you! -Eric
