On 1/4/19 4:12 PM, Darrick J. Wong wrote: > On Fri, Jan 04, 2019 at 03:27:37PM -0600, Eric Sandeen wrote: >> On 1/4/19 3:23 PM, Darrick J. Wong wrote: >>> From: Darrick J. Wong <darrick.wong@xxxxxxxxxx> >>> >>> Eric Sandeen recently found a bug in xfs_repair that flagged extended >>> attribute names containing "/" as corrupt and purged them. There's >>> nothing in the IRIX or Linux manuals that say anything about slashes not >>> being allowed (and Linux certainly allows this) so let's make sure this >>> continues to work. >>> >>> Signed-off-by: Darrick J. Wong <darrick.wong@xxxxxxxxxx> >>> --- >>> tests/generic/708 | 48 ++++++++++++++++++++++++++++++++++++++++++++++++ >>> tests/generic/708.out | 6 ++++++ >>> tests/generic/group | 1 + >>> 3 files changed, 55 insertions(+) >>> create mode 100755 tests/generic/708 >>> create mode 100644 tests/generic/708.out >>> >>> diff --git a/tests/generic/708 b/tests/generic/708 >>> new file mode 100755 >>> index 00000000..ee63ba79 >>> --- /dev/null >>> +++ b/tests/generic/708 >>> @@ -0,0 +1,48 @@ >>> +#! /bin/bash >>> +# SPDX-License-Identifier: GPL-2.0+ >>> +# Copyright (c) 2019 Oracle, Inc. All Rights Reserved. >>> +# >>> +# FS QA Test No. 708 >>> +# >>> +# Check that xattrs can have slashes in their name. >> >> Perhaps a note about what failed before? Because set/get/list has >> always(tm) worked: >> >> # (xfs_repair previously flagged this as a corruption) > > Ok. Reviewed-by: Eric Sandeen <sandeen@xxxxxxxxxx> (fine by me if that little change goes in on commit, not that important but adds some clarity about what got fixed IMHO)
