Re: [PATCH] iomap: Revert "fs/iomap.c: get/put the page in iomap_page_create/release()"

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Subject: Re: [PATCH] iomap: Revert "fs/iomap.c: get/put the page in iomap_page_create/release()"
From: Linus Torvalds <torvalds@xxxxxxxxxxxxxxxxxxxx>
Date: Fri, 21 Dec 2018 11:18:35 -0800
Cc: Dave Chinner <david@xxxxxxxxxxxxx>, linux-xfs@xxxxxxxxxxxxxxx, linux-fsdevel <linux-fsdevel@xxxxxxxxxxxxxxx>, Piotr Jaroszynski <pjaroszynski@xxxxxxxxxx>, william.kucharski@xxxxxxxxxx, stable@xxxxxxxxxxxxxxx, Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
In-reply-to: <20181221093919.GA2337@lst.de>
References: <20181220122324.17082-1-david@fromorbit.com> <20181220174130.GA21065@lst.de> <20181220205342.GC4205@dastard> <CAHk-=wgdbrbV+jNUmhJ7KZsR77CY+pUF7EmtxP2mWKnE8ZyFSQ@mail.gmail.com> <20181221093919.GA2337@lst.de>

Dave,
 any chance you can validate Christoph's patch and we could re-apply the fix?

             Linus

On Fri, Dec 21, 2018 at 1:39 AM Christoph Hellwig <hch@xxxxxx> wrote:
>
> As far as I can tell the commit simply missed updating the recounts
> in the actual migrate callback for which it was added.  The fixed
> version looks something like this (still running xfstests):

Follow-Ups:
- Re: [PATCH] iomap: Revert "fs/iomap.c: get/put the page in iomap_page_create/release()"
  - From: Dave Chinner
- Re: [PATCH] iomap: Revert "fs/iomap.c: get/put the page in iomap_page_create/release()"
  - From: Christoph Hellwig

References:
- [PATCH] iomap: Revert "fs/iomap.c: get/put the page in iomap_page_create/release()"
  - From: Dave Chinner
- Re: [PATCH] iomap: Revert "fs/iomap.c: get/put the page in iomap_page_create/release()"
  - From: Christoph Hellwig
- Re: [PATCH] iomap: Revert "fs/iomap.c: get/put the page in iomap_page_create/release()"
  - From: Dave Chinner
- Re: [PATCH] iomap: Revert "fs/iomap.c: get/put the page in iomap_page_create/release()"
  - From: Linus Torvalds
- Re: [PATCH] iomap: Revert "fs/iomap.c: get/put the page in iomap_page_create/release()"
  - From: Christoph Hellwig

Prev by Date: Re: Same size drive has less usable space
Next by Date: Re: [PATCH] iomap: Revert "fs/iomap.c: get/put the page in iomap_page_create/release()"
Previous by thread: Re: [PATCH] iomap: Revert "fs/iomap.c: get/put the page in iomap_page_create/release()"
Next by thread: Re: [PATCH] iomap: Revert "fs/iomap.c: get/put the page in iomap_page_create/release()"
Index(es):
- Date
- Thread

[Index of Archives] [XFS Filesystem Development (older mail)] [Linux Filesystem Development] [Linux Audio Users] [Yosemite Trails] [Linux Kernel] [Linux RAID] [Linux SCSI]