On Tue, Dec 18, 2018 at 03:38:28PM -0800, Darrick J. Wong wrote:
> > @@ -541,7 +541,7 @@ xfs_file_iomap_begin_delay(
> > struct xfs_bmbt_irec imap, cmap;
> > struct xfs_iext_cursor icur, ccur;
> > xfs_fsblock_t prealloc_blocks = 0;
> > - bool eof = false, cow_eof = false, shared;
> > + bool eof = false, cow_eof = false, shared = false;
> > int whichfork = XFS_DATA_FORK;
> > int error = 0;
> >
> > @@ -709,13 +709,14 @@ xfs_file_iomap_begin_delay(
> > if (imap.br_startoff > offset_fsb) {
> > xfs_trim_extent(&cmap, offset_fsb,
> > imap.br_startoff - offset_fsb);
> > - error = xfs_bmbt_to_iomap(ip, iomap, &cmap, false);
> > + error = xfs_bmbt_to_iomap(ip, iomap, &cmap, true);
>
> Does this belong in the previous patch? (Maybe all of it?)
Not really, as it is just a nice to have thing that is a change of
behavior to what we did before. So I'd rather have it in a single
patch that documents what exactly we did here and why.
