On Tue, Dec 18, 2018 at 01:44:25PM -0800, Darrick J. Wong wrote: > > + uint *lockmode, > > + unsigned flags) > > I'm not thrilled with passing iomap flags into the reflink code here... So what is the alternative? A non-descriptive bool argument? > ...because I feel that it's easy to miss the subtlety here that for > buffered writes we don't care if the cow extent is unwritten or written, > but for directio we very /much/ care that the cow extent is written, > because we're writing to it immediately. Can this grow a comment to > reinforce why we skip the conversion? Sure. > Also, can we call this 'iomap_flags' to make it clearer which flags > we're talking about? Sure.
