On 11/28/18 5:29 PM, Darrick J. Wong wrote: > From: Darrick J. Wong <darrick.wong@xxxxxxxxxx> > > Move XFS_INODE_FORMAT_STR to libxfs so that we don't forget to keep it > updated, and add necessary TRACE_DEFINE_ENUM. > > Signed-off-by: Darrick J. Wong <darrick.wong@xxxxxxxxxx> ... > diff --git a/fs/xfs/xfs_trace.h b/fs/xfs/xfs_trace.h > index 3f57002ca660..94e289aca220 100644 > --- a/fs/xfs/xfs_trace.h > +++ b/fs/xfs/xfs_trace.h > @@ -1901,11 +1901,11 @@ TRACE_EVENT(xfs_dir2_leafn_moveents, > { 0, "target" }, \ > { 1, "temp" } ^^^^ that context makes me wonder if we shouldn't move that #define as well, and give 0 & 1 some meaningful macro names. Patch 7/6? :) -Eric