On Wed, Dec 05, 2018 at 02:51:47PM -0800, Christoph Hellwig wrote: > XFS currently uses kmalloc for buffers smaller than the page size to > avoid wasting too much memory. But this can cause a problem with slub > debugging turned on as the allocations might not be naturally aligned. > On block devices that require sector size alignment this can lead to > data corruption. > > Give that our smaller than page size buffers are always sector sized > on a live file system, we can just create a kmem_cache with an > explicitly specified alignment requirement for this case to fix this > case without much effort. > > Signed-off-by: Christoph Hellwig <hch@xxxxxx> Looks good now. I'll throw it in my test kernels because I've got a mix of different sector size configs I test against and see if anything whacky falls out... Reviewed-by: Dave Chinner <dchinner@xxxxxxxxxx> Cheers, Dave. -- Dave Chinner david@xxxxxxxxxxxxx
