On Wed, Dec 05, 2018 at 11:33:46PM +0100, Christoph Hellwig wrote: > On Thu, Dec 06, 2018 at 09:31:39AM +1100, Dave Chinner wrote: > > > > > > That's fine because log recovery is one I/O at a time, and we always > > > free the current buffer before allocating the next one, so we'd waste > > > the memory one way or another. > > > > True. Can you mention this in the commit message so it gets recorded > > with the change and doesn't get lost in the mists of time? > > How about a comment instead of the commit message? Either way I can > document this decision for v2. That's fine by me, too. Cheers, Dave. -- Dave Chinner david@xxxxxxxxxxxxx
