On 12/4/18 10:48 PM, Eric Sandeen wrote:
> On 11/1/18 5:47 AM, Jan Tulak wrote:
>> Some distributions, like Fedora, have /bin and /sbin as symlinks
>> pointing to /usr/* and this patch adds compatibility for these cases.
>
> xfsdump builds fine on Fedora, but only because somebody (me) was
> bad long long ago, in the spec file:
>
> # Bit of a hack to move files from /sbin to /usr/sbin
> (cd $RPM_BUILD_ROOT/%{_sbindir}; rm xfsdump xfsrestore)
> (cd $RPM_BUILD_ROOT/%{_sbindir}; mv ../../sbin/xfsdump .)
> (cd $RPM_BUILD_ROOT/%{_sbindir}; mv ../../sbin/xfsrestore .)
>
> I ... don't know why that was done. Seems like dump/restore /should/
> just live in /sbin, no? I'm not sure what the symlink is/was for
> in the first place...
>
> but I guess Debian does package it up that way:
>
> # dpkg-query -L xfsdump | grep xfsrestore | xargs ls -l
> -rwxr-xr-x 1 root root 246088 Aug 1 2014 /sbin/xfsrestore
> lrwxrwxrwx 1 root root 16 Aug 1 2014 /usr/sbin/xfsrestore -> /sbin/xfsrestore
>
> so, um, I guess this seems ok to handle the /sbin == /usr/sbin case.
>
> Reviewed-by: Eric Sandeen <sandeen@xxxxxxxxxx>
Heh, ok, yes your fix is what I should have done 6 years ago :D
Thanks,
-Eric
