Re: [PATCH 1/4] xfsdump: (style) remove trailing whitespaces

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 11/28/18 10:56 AM, Jan Tulak wrote:
> There were many trailing whitespaces through the whole code. As the rate
> of changes in xfsdump is low, it should not cause trouble if we fix it
> in all files at once and avoid issues (unintended changes) with sensibly
> configured editors that automatically remove these on a file save.
> 
> Can be tested with objdump.
> 
> Created by this script:
> 
> #!/usr/bin/env bash
> # remove trailing whitespaces
> 
> find . -name '*.[ch]' ! -type d -exec bash -c '
> sed -i \
>     -e "s/\s*$//" \
>     $0
> ' {} \;
> 
> Signed-off-by: Jan Tulak <jtulak@xxxxxxxxxx>

Hi Jan - 

Finally got to looking at these, but this patch doesn't apply for me
(even if retrieved from patchwork)

...


> diff --git a/common/arch_xlate.c b/common/arch_xlate.c
> index 1b8e687..4043a9d 100644
> --- a/common/arch_xlate.c
> +++ b/common/arch_xlate.c
> @@ -135,12 +135,12 @@ xlate_drive_hdr(drive_hdr_t *dh1, drive_hdr_t *dh2, int dir)
>  	     "\tdh_pad1 %s\n"
>  	     "\tdh_specific %s\n"
>  	     "\tdh_upper %s\n",
> -	     ptr1->dh_drivecnt,
> +	     ptr1->dh_drivecnt,
>  	     ptr1->dh_driveix,
>  	     ptr1->dh_strategyid,
>  	     ptr1->dh_pad1,
>  	     ptr1->dh_specific,
> -	     ptr1->dh_upper);
> +	     ptr1->dh_upper);


...

there seems to be no actual trailing whitespace on the "-" lines?

-Eric



[Index of Archives]     [XFS Filesystem Development (older mail)]     [Linux Filesystem Development]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux RAID]     [Linux SCSI]


  Powered by Linux