On Thu, Nov 29, 2018 at 08:48:25PM -0600, Eric Sandeen wrote: > xfs_btree_sblock_verify_crc is a bool so should not be returning > a failaddr_t; worse, if xfs_log_check_lsn fails it returns > __this_address which looks like a boolean true (i.e. success) > to the caller. > > (interestingly xfs_btree_lblock_verify_crc doesn't have the issue) > > Signed-off-by: Eric Sandeen <sandeen@xxxxxxxxxx> Looks good, Reviewed-by: Christoph Hellwig <hch@xxxxxx>