On 11/28/18 5:34 PM, Darrick J. Wong wrote: > On Wed, Nov 28, 2018 at 04:39:47PM -0600, Eric Sandeen wrote: >> On 11/9/18 6:45 PM, Darrick J. Wong wrote: >>> From: Darrick J. Wong <darrick.wong@xxxxxxxxxx> >>> >>> Most of the commands listed under "OTHER COMMANDS" apply to files or >>> filesystems. Create two new sections for that and populate them >>> appropriately. >>> >>> Here's what moves: >>> >>> fsmap: moves from file io commands to filesystem commands >>> utimes: moves from file io commands to file commands >>> >>> >From the OTHER COMMANDS section: >>> >>> lsattr/chattr: moves to file commands >>> flink: moves to file commands >>> stat/statx: moves to file commands >>> lsproj/chproj: moves to file commands >>> parent: moves to file commands >>> [gs]et_encpolicy: moves to file io commands >>> freeze/thaw: move to filesystem commands >>> inject: move to filesystem commands >>> resblks: move to filesystem commands >>> shutdown: move to filesystem commands >>> statfs: move to filesystem commands >>> label: move to filesystem commands >> >> Thank you for getting this better organized. Of course, I have >> some questions. :) >> >> What does "FILE COMMANDS" vs. "FILE I/O COMMANDS" mean, exactly? >> I ask because for example bmap & fiemap are still under FILE IO but >> they... really don't do file IO. What's your intended distinction >> with these new sections? > > Admittedly, it's been a looong time since I wrote this patch. yeah, that's my fault, sorry. > Um... I think my intent was for FILE COMMANDS to pertain to file > attributes, whereas FILE I/O COMMANDS would pertain to reading, writing, > encoding, mapping, and otherwise messing with the contents of a file. Because the distinction requires a fair bit of explanation I think it'd be better to just lump them all into FILE OPERATIONS i.e. "these operate on individual files not the filesystem in general." Explicitly re-categorizing into rather vague categories doesn't seem overly helpful. :) -Eric
