Hi all, Here are fixes for some problems with the inode btree scrub code, namely that the existing code does not handle the case where a single inode cluster is mapped by multiple inobt records. Patch 1 teaches the inode record block counting code to handle the case where there's more than one inobt record per inode cluster. We do this by counting inodes and converting to blocks only at the end. Patch 2 corrects a condition where we needed to clamp the number of inodes checked for a given inobt record to the inode chunk size. Patches 3-4 move the inobt record alignment checks to a separate function and enhance the function to check that when we have more than one inobt record per cluster we actually check that *all* of the necessary records are present and in the correct order. Patches 5-7 reorganize the inobt free data checks to deal with the "multiple inobt records per icluster" situation. In restructuring the code to do so, we also rename variables and functions to be less confusing about what they're there for. We also fix the 'is the inode free?' check to calculate dinode buffer offsets correctly in the "multiple inobt records per icluster" situation. Patch 8 aborts the xattr scrub loop if there are pending fatal signals. Patch 9 checks that for any directory or attr fork there are no extent maps that stretch beyond what a xfs_dablk_t can map. If you're going to start using this mess, you probably ought to just pull from my git trees. The kernel patches[1] should apply against 4.20-rc4. Comments and questions are, as always, welcome. --D [1] https://git.kernel.org/cgit/linux/kernel/git/djwong/xfs-linux.git/log/?h=djwong-devel
