On Tue, Nov 20, 2018 at 08:17:42AM +1100, Dave Chinner wrote: > From: Dave Chinner <dchinner@xxxxxxxxxx> > > It returns EINVAL when the operation is not supported by the > filesystem. Fix it to return EOPNOTSUPP to be consistent with > the man page and clone_file_range(). > > Clean up the inconsistent error return handling while I'm there. > (I know, lipstick on a pig, but every little bit helps...) > > Signed-off-by: Dave Chinner <dchinner@xxxxxxxxxx> > Reviewed-by: Darrick J. Wong <darrick.wong@xxxxxxxxxx> Looks good. And I really like the removal of the pointless goto out uses.. Reviewed-by: Christoph Hellwig <hch@xxxxxx>