From: Dave Chinner <dchinner@xxxxxxxxxx> Just tried to punch a 40T sparse file when enospc was triggered due to extent size hints consuming more space than expected. It failed with: # sudo xfs_io -c "fpunch 0 40t" /mnt/fast/xfs-arekm.img fallocate: No space left on device # because the writeback error of ENOSPC was being reported. We're going to free that space, so we don't care if there was a ENOSPC writeback error. So ignore ENOSPC errors and punch anyway. Signed-off-by: Dave Chinner <dchinner@xxxxxxxxxx> --- fs/xfs/xfs_bmap_util.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/fs/xfs/xfs_bmap_util.c b/fs/xfs/xfs_bmap_util.c index 167ff4297e5c..cc7a0d47c529 100644 --- a/fs/xfs/xfs_bmap_util.c +++ b/fs/xfs/xfs_bmap_util.c @@ -1060,8 +1060,13 @@ xfs_flush_unmap_range( start = round_down(offset, rounding); end = round_up(offset + len, rounding) - 1; + /* + * We're going to trash the data in this range, so if writeback reports + * an enospc error, don't let it stop us from /freeing the space/ in the + * range to alleviate the ENOSPC condition. + */ error = filemap_write_and_wait_range(inode->i_mapping, start, end); - if (error) + if (error && error != -ENOSPC) return error; truncate_pagecache_range(inode, start, end); return 0; -- 2.19.1
