On Sun, Nov 18, 2018 at 09:44:56PM +0800, Eryu Guan wrote:
> > +#! /bin/bash
> > +# SPDX-License-Identifier: GPL-2.0
> > +# Copyright (c) 2000-2003 Silicon Graphics, Inc. All Rights Reserved.
>
> Hmm, I think it's better to write proper Copyright information for new
> tests,
I'm not the copyright holder, so I can't easily change this. But
except for the odd All Rights reserved the above seems to be exactly
the style we use now.
> > +_cleanup()
> > +{
> > + cd /
> > + rm -rf $TEST_DIR/fsx.* $tmp.*
> > +}
>
> Use tab as indention. Please ./new to generate new test template, so all
> has been taken care of.
I can replace spaces with tabs, but I don't want to regenerate the whole
tests. In the it should stick to what we originally tested as much
as possible.
I'll look into the other changes.
