Re: [PATCH] xfs: make xfs_file_remap_range() static

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 11/14/18 6:12 PM, Eric Biggers wrote:
From: Eric Biggers <ebiggers@xxxxxxxxxx>

xfs_file_remap_range() is only used in fs/xfs/xfs_file.c, so make it
static.

This addresses a gcc warning when -Wmissing-prototypes is enabled.

Signed-off-by: Eric Biggers <ebiggers@xxxxxxxxxx>
---
  fs/xfs/xfs_file.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/xfs/xfs_file.c b/fs/xfs/xfs_file.c
index 53c9ab8fb777f..e47425071e654 100644
--- a/fs/xfs/xfs_file.c
+++ b/fs/xfs/xfs_file.c
@@ -920,7 +920,7 @@ xfs_file_fallocate(
  }
-loff_t
+STATIC loff_t
  xfs_file_remap_range(
  	struct file		*file_in,
  	loff_t			pos_in,


Looks ok to me.  You can add my review:
Reviewed-by: Allison Henderson <allison.henderson@xxxxxxxxxx>

Thanks!
Allison



[Index of Archives]     [XFS Filesystem Development (older mail)]     [Linux Filesystem Development]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux RAID]     [Linux SCSI]


  Powered by Linux