On Mon, 2018-11-12 at 10:33 +1100, Dave Chinner wrote: > On Sun, Nov 11, 2018 at 08:36:03AM +0800, hmsjwzb wrote: > > Possible unwrapped commit description (prefer a maximum 75 chars per line) > > NACK. Our preference is (and always has been) for comments to fill > the entire 80 columns, just like the rest of the kernel. I have no > idea who told you "75 columns is preferred" but they are wrong. 75 column is the preferred commit description length as the general 'git log' style is indented a few chars. This particular commit description is odd because the comments in the code is being wrapped, not the commit description. Wei Zhe, can you please resubmit this with a better commit description? Something like: Wrap comments to 80 columns where appropriate.
