On Fri, Oct 26, 2018 at 12:18:51PM -0700, Darrick J. Wong wrote: > The downside of this is that now we have to declare all those functions > somewhere so that the fs/xfs/ and libxfs/defer_item.c can match the > prototypes. I don't think that is worth the pain vs the version I posted. I don't think removing a single indirection really buys us so much as to expose all the internals.