Re: xfsdump cleaning patchset

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




On 10/23/18 3:16 AM, Jan Tulak wrote:
>> I'm not a huge fan of "fix buffer overflows by making them arbitrarily
>> bigger" - can we use i.e. snprintf to make sure it won't happen again,
>> and maybe size them based on ... something, instead of "eh, [5000] is
>> hopefully enough?"
> I based the new size on gcc outputs, it said how much it can overflow.
> But I checked the numbers only once or twice and didn't verify it for
> other reports.

It's always possible that I'm wrong and I'm missing something.  :)
What did gcc say for the cases I pointed out?

> Sure. Well, back to the drawing board. 

Eh not entirely, just recheck some stuff.  Just make sure you keep
the big picture in mine when you're looking at coverity reports.

Thanks,
-Eric



[Index of Archives]     [XFS Filesystem Development (older mail)]     [Linux Filesystem Development]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux RAID]     [Linux SCSI]


  Powered by Linux