On 10/15/18 11:03 AM, Darrick J. Wong wrote:
> From: Darrick J. Wong <darrick.wong@xxxxxxxxxx>
>
> Don't treat a lack of kernel support for scrubbing as an automated
> service failure because we have not actually determined that there's
> anything wrong with the filesystem.
>
> Signed-off-by: Darrick J. Wong <darrick.wong@xxxxxxxxxx>
makes sense to me
Reviewed-by: Eric Sandeen <sandeen@xxxxxxxxxx>
> ---
> scrub/xfs_scrub.c | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/scrub/xfs_scrub.c b/scrub/xfs_scrub.c
> index 33b83a5f..6a0304d2 100644
> --- a/scrub/xfs_scrub.c
> +++ b/scrub/xfs_scrub.c
> @@ -779,9 +779,15 @@ main(
> * for capturing all the log messages if the scrub fails, because the
> * fail service uses the service name to gather log messages for the
> * error report.
> + *
> + * Note: We don't count a lack of kernel support as a service failure
> + * because we haven't determined that there's anything wrong with the
> + * filesystem.
> */
> if (is_service) {
> sleep(2);
> + if (!ctx.scrub_setup_succeeded)
> + return 0;
> if (ret != SCRUB_RET_SUCCESS)
> return 1;
> }
>
