On Thu, Oct 11, 2018 at 3:36 PM Eric Sandeen <sandeen@xxxxxxxxxxx> wrote: > Thanks. At this point I think you have a better grasp of what all the > $FOO_FLAGS do than I do ;) It may be to keep things sorted > and separate, but it also seemed useful to get a giant tangle of > xfs header out of a non-xfs library file. Yep! I'm happy with this patch. If I'm bothered enough, I can still send another patch to sort out the flags further. > I'm also on the fence about whether cross-compiling the self-check > really even gains us much, given that it may be built or optimized > completely differently from the code on the target arch ... I don't have a whole lot of opinion here. Regards, Brian
