On 10/11/18 12:57 AM, Christoph Hellwig wrote:
>> -sparse and gcc using:
>> +The xfsprogs Makefile has a convenient shortcut to running sparse, by setting
>> +the C ("check") variable on the make commandline. To perform generic checks,
>> +
>> + make C=1
>> +
>> +which checks with -Wsparse-all -Wno-transparent-union -Wno-return-void
>> +-Wno-undef -Wno-non-pointer-null, or to perform the bitwise checks, use
>> +
>> + make C=2
>> +
>> +which checks with -Wbitwise -D__CHECK_ENDIAN__
>
> Out of all the sparce checks applicable to xfsprogs endianess is by
> far the most impotant one. I don't think it makes any sense to ever
> turn it off..
Oh... whoops, I thought I was emulating kernel behavior (by following e2fsprogs
behavior), but sadly no:
> Do a kernel make with "make C=1" to run sparse on all the C files that get
> recompiled, or use "make C=2" to run sparse on the files whether they need to
> be recompiled or not. The latter is a fast way to check the whole tree if you
> have already built it.
Let me see if I can properly mimic that behavior, with endian checking baked
in for both.
Thanks for bringing it up,
-Eric
