Re: [PATCH 13/18] xfs_io: rename global buffer variable

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Oct 10, 2018 at 03:01:17PM -0500, Eric Sandeen wrote:
> "buffer" is a pretty poor name for a global variable, and leads to
> shadow variable warnings from sparse when other functions (reasonably)
> think it's a nice local variable name.
> 
> Rename it to io_buffer for less namespace pollution, and rename
> buffersize to io_buffersize to go with it.
> 
> Signed-off-by: Eric Sandeen <sandeen@xxxxxxxxxx>

Looks good,

Reviewed-by: Christoph Hellwig <hch@xxxxxx>



[Index of Archives]     [XFS Filesystem Development (older mail)]     [Linux Filesystem Development]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux RAID]     [Linux SCSI]


  Powered by Linux