> @@ -385,4 +385,7 @@ extern int xfs_setsize_buftarg(xfs_buftarg_t *, unsigned int); > #define xfs_getsize_buftarg(buftarg) block_size((buftarg)->bt_bdev) > #define xfs_readonly_buftarg(buftarg) bdev_read_only((buftarg)->bt_bdev) > > +extern int xfs_buf_ensure_ops(struct xfs_buf *bp, > + const struct xfs_buf_ops *ops); While we are nitpicking: no need to have an extern in function prototypes ever. Modulo that and the nitpicks from Brian this looks fine to me: Reviewed-by: Christoph Hellwig <hch@xxxxxx>