On Thu, Oct 04, 2018 at 11:03:15PM -0500, Eric Sandeen wrote: > From: Eric Sandeen <sandeen@xxxxxxxxxx> > > None of these seem activel harmful, but to avoid confusion, remove all > shadow variables by just renaming them in their local scope. > > Fixes sparse warnings about this. I'd feel much more comforable reviewing this with one patch per function that explains why the transformation is safe, especially as the patch itself contradicts the explanation above - some variables are removed instead of renamed for example.
