On Thu, Oct 04, 2018 at 11:03:13PM -0500, Eric Sandeen wrote: > From: Eric Sandeen <sandeen@xxxxxxxxxx> > > The EXTERN macro was a too-clever hack to allow a header file to both > declare global variables and export them. Get rid of the hack and do > things the predictable way. > > Signed-off-by: Eric Sandeen <sandeen@xxxxxxxxxx> > Signed-off-by: Eric Sandeen <sandeen@xxxxxxxxxxx> > --- > repair/globals.c | 123 ++++++++++++++++++++++++++++++++++++++++++++++-- > repair/globals.h | 136 +++++++++++++++++++++++++++--------------------------- > repair/versions.c | 23 +++++++-- > repair/versions.h | 16 +++---- > 4 files changed, 214 insertions(+), 84 deletions(-) > > diff --git a/repair/globals.c b/repair/globals.c > index d00e964..e963edb 100644 > --- a/repair/globals.c > +++ b/repair/globals.c > @@ -1,10 +1,125 @@ > // SPDX-License-Identifier: GPL-2.0 > /* > - * Copyright (c) 2000-2001,2005 Silicon Graphics, Inc. > + * Copyright (c) 2000-2002,2005 Silicon Graphics, Inc. This doesn't look related. Otherwise this looks good: Reviewed-by: Christoph Hellwig <hch@xxxxxx>
