On 10/5/18 10:41 AM, Darrick J. Wong wrote: > On Thu, Oct 04, 2018 at 11:03:01PM -0500, Eric Sandeen wrote: >> A handful of sparse fixes, more or less one patch per issue. > > Mostly looks fine except for the things I complained about on IRC: > > Patch 7 commit message ought to identify the other definer of MS_ > constants. > > Patch 14 commit message has a typo "activel". > > *progname probably should be in libfrog.h so that scrub doesn't > have to include libxfs.h (scrub doesn't link against libxfs) (patch 11). > > Reviewed-by: Darrick J. Wong <darrick.wong@xxxxxxxxxx> Will fix, scout's honor, thanks for the review. -Eric
