On Wed, Oct 03, 2018 at 02:35:36PM +0200, Carlos Maiolino wrote: > The addition of FIBT, RMAP and REFCOUNT changed the offsets into > __xfssats structure. > > Although this didn't cause any direct issue, xqmstat_proc_show() relied > on the old offsets to display the xqm statistics. > > Fix it. > > Signed-off-by: Carlos Maiolino <cmaiolino@xxxxxxxxxx> > --- > fs/xfs/xfs_stats.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/fs/xfs/xfs_stats.c b/fs/xfs/xfs_stats.c > index 4e4423153071..740ac9674848 100644 > --- a/fs/xfs/xfs_stats.c > +++ b/fs/xfs/xfs_stats.c > @@ -119,7 +119,7 @@ static int xqmstat_proc_show(struct seq_file *m, void *v) > int j; > > seq_printf(m, "qm"); > - for (j = XFSSTAT_END_IBT_V2; j < XFSSTAT_END_XQMSTAT; j++) > + for (j = XFSSTAT_END_REFCOUNT; j < XFSSTAT_END_XQMSTAT; j++) /me totally missed that when I was writing reflink, sorry. :( Can we have a: #define XFSSTAT_START_XQMSTAT (XFSSTAT_END_REFCOUNT) in xfs_stats.h right above the XFSSTAT_END_XQMSTAT definition so that future authors don't have to remember that some code use _END_REFCOUNT to mean "start of next thing"? --D > seq_printf(m, " %u", counter_val(xfsstats.xs_stats, j)); > seq_putc(m, '\n'); > return 0; > -- > 2.17.1 >
