On Fri, Sep 28, 2018 at 01:39:56PM -0400, Brian Foster wrote: > This problem is reliably reproduced by generic/083 on XFS on ppc64 > systems (64k page size, 4k block size). It results in leaked > delalloc blocks on inode reclaim, which triggers an assert failure > in xfs_fs_destroy_inode() and filesystem accounting inconsistency. Interesting - I've not seen this on 1k block size / 4k page size systems. > This patch addresses the problem with generic/083, but I'm still in the > process of running broader testing. I wanted to get it on the list for > review in the meantime... But in general this looks sensible to me. So if the testing passes this looks good to me.