On Wed, Sep 26, 2018 at 11:17:12AM -0400, Brian Foster wrote: > With this change, it looks like that scenario plays out the same until > we get to imap_needs_alloc(), which returns true and brings us to do an > allocation... I guess this changes a bit in the follow on patches, but > the IOMAP_ZERO check that remains still makes the logic look funny. > Should we ever get here with IOMAP_ZERO after the final patch to switch > to separate ops? Good point. I thought we wouldn't ever get here, but until the next patch that isn't actually true. I'll reorder and add asserts.