Re: [PATCH 1/2] scrub: remove redundant debug test

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Sep 26, 2018 at 04:25:12PM -0500, Eric Sandeen wrote:
> From: Eric Sandeen <sandeen@xxxxxxxxxx>
> 
> debug_tweak_on() already tests for debug.
> 
> Signed-off-by: Eric Sandeen <sandeen@xxxxxxxxxx>

Looks ok,
Reviewed-by: Darrick J. Wong <darrick.wong@xxxxxxxxxx>

--D

> ---
> 
> diff --git a/scrub/xfs_scrub.c b/scrub/xfs_scrub.c
> index 076a86a..33b83a5 100644
> --- a/scrub/xfs_scrub.c
> +++ b/scrub/xfs_scrub.c
> @@ -425,7 +425,7 @@ run_scrub_phases(
>  	unsigned int		nr_threads;
>  	int			rshift;
>  
> -	if (debug && debug_tweak_on("XFS_SCRUB_PHASE"))
> +	if (debug_tweak_on("XFS_SCRUB_PHASE"))
>  		debug_phase = atoi(getenv("XFS_SCRUB_PHASE"));
>  
>  	/* Run all phases of the scrub tool. */
> 



[Index of Archives]     [XFS Filesystem Development (older mail)]     [Linux Filesystem Development]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux RAID]     [Linux SCSI]


  Powered by Linux