On Thu, Sep 06, 2018 at 03:55:34PM -0700, Brian Norris wrote: > On Thu, Sep 06, 2018 at 05:33:56PM -0500, Eric Sandeen wrote: > > I was trying to just get the selftest to build with a custom set of > > userspace headers, like the patch below, so we don't have to pull in all > > the various and sundry xfs headers & dependencies. Not sure what the better > > approach is here ... > > I think an ideal goal is still to remove all usage of HAVE_* from > anything that gets built with $BUILD_CC. I guess that's just > crc32selftest? So even if you do that, it would still be good to do > something like my patch. (Maybe even more than that -- remove the BLKID, > FSETXATTR, etc., flags from $BUILD_CFLAGS.) > > But your patch does work for me. (Well, I had to port it back a little, > since my cross-compilation environment isn't building off the > development tip.) Ping? Should I send a new version that combines our patches? Regards, Brian