Hi guys I see that there are some failed assertions in the xfs/191 test and they can be sorted into a few categories: pass -n size=2b /dev/sda2 pass -d agsize=8192b /dev/sda2 pass -d agsize=65536s /dev/sda2 pass -l su=10b /dev/sda2 pass -d su=4096s,sw=64 /dev/sda2 pass -d su=4096b,sw=64 /dev/sda2 Here mkfs assumes a default block/sector size, so these checks can be deleted. fail -n log=15 /dev/sda2 fail -i log=10 /dev/sda2 These checks can be removed too, log sizes have been removed from mkfs.xfs. pass -d su=0,sw=64 /dev/sda2 And if I understand the current behaviour, -d su=0 is the same as su not used at all, so this check should be changed to expect pass instead of fail. Everyone agrees with this assessment that the test 191 needs to be updated and none of this is a bug of mkfs? Cheers, Jan -- Jan Tulak jtulak@xxxxxxxxxx / jan@xxxxxxxx
