Re: [PATCH] xfs: re-enable FIBMAP on reflink; disable for swap

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Sep 12, 2018 at 08:55:35PM -0500, Eric Sandeen wrote:
> The commit:
> 
>  db1327b1 xfs: report shared extent mappings to userspace correctly
> 
> disabled FIBMAP on reflinked files, with this very clear rationale
> regarding swapfiles:
> 
> "Have xfs_vm_bmap return zero for reflinked files because the
> bmap-based swap code requires static block mappings, which is
> incompatible with copy on write."
> 
> However, this broke the FIBMAP interface for existing userspace
> apps, including bootloaders.

It didn't break any interface because the reflink flag has been
experimental and a mkfs-time opt in.

So NAK for this patch.



[Index of Archives]     [XFS Filesystem Development (older mail)]     [Linux Filesystem Development]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux RAID]     [Linux SCSI]


  Powered by Linux