Today, we can get an interesting result when mounting a reflink filesystem
with -o dax on a device that doesn't support it:
XFS (sda1): DAX enabled. Warning: EXPERIMENTAL, use at your own risk
XFS (sda1): DAX unsupported by block device. Turning off DAX.
XFS (sda1): DAX and reflink cannot be used together!
<fail mount>
If we're willing to silently turn off DAX due to incompatibility with the
block device, it makes no sense to then fail the mount due to
incompatibility with the filesystem format. So, skip this check if we
already decided to turn off DAX and proceed.
Signed-off-by: Eric Sandeen <sandeen@xxxxxxxxxx>
---
diff --git a/fs/xfs/xfs_super.c b/fs/xfs/xfs_super.c
index 207ee30..c85c432 100644
--- a/fs/xfs/xfs_super.c
+++ b/fs/xfs/xfs_super.c
@@ -1677,8 +1677,7 @@ struct proc_xfs_info {
xfs_alert(mp,
"DAX unsupported by block device. Turning off DAX.");
mp->m_flags &= ~XFS_MOUNT_DAX;
- }
- if (xfs_sb_version_hasreflink(&mp->m_sb)) {
+ } else if (xfs_sb_version_hasreflink(&mp->m_sb)) {
xfs_alert(mp,
"DAX and reflink cannot be used together!");
error = -EINVAL;
