On Tue, Sep 04, 2018 at 07:11:12PM +1000, Dave Chinner wrote: > On Tue, Sep 04, 2018 at 09:26:00AM +0100, Richard W.M. Jones wrote: > > Yes I think I was far too hasty declaring this a problem with mkfs.xfs > > last night. It turns out that NBD on the wire can only describe a few > > different errors and maps any other error to -EINVAL, which is likely > > Urk. It should map them to -EIO, because then we know it's come from > the IO layer and isn't a problem related to userspace passing the > kernel invalid parameters. Actually EIO is one of the errors that NBD does understand :-) Rich. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones Read my programming and virtualization blog: http://rwmj.wordpress.com Fedora Windows cross-compiler. Compile Windows programs, test, and build Windows installers. Over 100 libraries supported. http://fedoraproject.org/wiki/MinGW
