[add linux-xfs to cc] On Fri, Aug 31, 2018 at 07:31:25AM +0200, Matthias Bodenbinder wrote: > Hello Darrick, > > you are named as maintainer in the xfs_scrub_all python script which is > coming with Manjaro Linux. Therefore I am writing to you about a > "cosmetic" issue with invalid unit names. > > I have / and /home setup as XFS. When I run the script I get the > following output: > > 1# xfs_scrub_all > Scrubbing /home... > Invalid unit name "xfs_scrub@/home" was escaped as "xfs_scrub@-home" > (maybe you should use systemd-escape?) Oh, lovely, systemd changed their escaping rules again... > Starting Online XFS Metadata Check for /home... > EXPERIMENTAL xfs_scrub program in use! Use at your own risk! > Info: AG 1 superblock: Optimization is possible. > Info: AG 2 superblock: Optimization is possible. > Info: AG 3 superblock: Optimization is possible. > Scrubbing /home done, (err=0) > Scrubbing /... > Invalid unit name "xfs_scrub@/" was escaped as "xfs_scrub@-" (maybe you > should use systemd-escape?) > Started Online XFS Metadata Check for /home. > Scrubbing / done, (err=0) > > Can you fix that? I think so. If you remove the lines: if '-' not in path: return path from systemd_escape() in /sbin/xfs_scrub_all, do the warnings go away? Does scrub still work afterwards? --D > > Thanks > > Matthias > >
