On Tue, Jul 31, 2018 at 10:39 PM, Eric Sandeen <sandeen@xxxxxxxxxxx> wrote:
>
>
> On 7/31/18 11:37 PM, Chris Murphy wrote:
>> On Tue, Jul 31, 2018 at 10:21 PM, Dave Chinner <david@xxxxxxxxxxxxx> wrote:
>>> On Tue, Jul 31, 2018 at 08:02:17PM -0600, Chris Murphy wrote:
>>>> Hi,
>>>> I'm doing this on Fedora 28, I'm including the entire output from
>>>> exporting environment variables from doc/INSTALL so it's kinda long...
>>>>
>>>> [chris@f28s xfsprogs-dev]$ git reset --hard origin/master
>>>> HEAD is now at 0821de47 xfsprogs: Release v4.17.0
>>>>
>>>> [chris@f28s xfsprogs-dev]$ export TAR=/usr/bin/tar
>>>> [chris@f28s xfsprogs-dev]$ export LIBTOOL=/usr/bin/libtool
>>>> [chris@f28s xfsprogs-dev]$ export INSTALL_GROUP=wheel
>>>> [chris@f28s xfsprogs-dev]$ export
>>>> LOCAL_CONFIGURE_OPTIONS="--enable-gettext=no --enable-blkid=no
>>>> --enable-librt=no"
>>>
>>> You shot yourself in the foot.
>>>
>>> ....
>>>> [CC] versions.o
>>>> [CC] xfs_repair.o
>>>> [LD] xfs_repair
>>>> /tmp/cc95QLol.ltrans8.ltrans.o: In function `progress_rpt_thread.lto_priv.352':
>>>> <artificial>:(.text+0xa2c9): undefined reference to `timer_create'
>>>> <artificial>:(.text+0xa2e4): undefined reference to `timer_settime'
>>>> <artificial>:(.text+0xa570): undefined reference to `timer_delete'
>>>
>>> These functions are in librt, and you told the build not to use it...
>>
>>
>> I did what doc/INSTALL told me to do:
>>
>> Building xfsprogs:
>>
>> [firstly set these environment variables to these values]
>> TAR=/usr/bin/gnutar
>> LIBTOOL=/usr/bin/glibtool
>> INSTALL_GROUP=wheel
>> LOCAL_CONFIGURE_OPTIONS="\
>> --enable-gettext=no\
>> --enable-blkid=no\
>> --enable-librt=no\
>> "
>
> Wow, no idea why that crap is in there, it should probably be removed.
>
> Just "make" will suffice.
>
> Patches accepted :)
And then I found the xfsprogs.spec file for Fedora 29's xfsprogs which contains:
%configure \
--enable-readline=yes \
--enable-blkid=yes \
--enable-lto=no
That too blows up, likely because I don't have readline-devel.x86_64 installed.
...
Building libxcmd
[CC] command.lo
[CC] input.lo
input.c:25:11: fatal error: readline/history.h: No such file or directory
# include <readline/history.h>
^~~~~~~~~~~~~~~~~~~~
compilation terminated.
gmake[3]: *** [../include/buildrules:56: input.lo] Error 1
gmake[2]: *** [include/buildrules:36: libxcmd] Error 2
make[1]: *** [Makefile:77: default] Error 2
make: *** [Makefile:74: default] Error 2
[chris@f28s xfsprogs-dev]$
And starting over without any environment variables set from
doc/INSTALL and that now works. :-P
--
Chris Murphy
--
To unsubscribe from this list: send the line "unsubscribe linux-xfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
