Re: [PATCH 15/15] xfs: fold dfops into the transaction

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Jul 31, 2018 at 01:36:03AM -0700, Christoph Hellwig wrote:
> > -	trace_xfs_defer_trans_abort(tp->t_mountp, dop, _RET_IP_);
> > +	trace_xfs_defer_trans_abort(tp->t_mountp, tp, _RET_IP_);
> 
> Can't we stop passing the explicit xfs_mount to these tracepoints now?
> 

I thought I tried that and ran into xfs_trans definition issues. Looking
again, I see that we're using ->t_mountp in other tracepoints so perhaps
something else was going on. I don't recall exactly so I'll make another
pass and try to clean these up wherever we have a transaction.

Brian

> Otherwise looks good:
> 
> Reviewed-by: Christoph Hellwig <hch@xxxxxx>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-xfs" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-xfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [XFS Filesystem Development (older mail)]     [Linux Filesystem Development]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux RAID]     [Linux SCSI]


  Powered by Linux