> > + error = xfs_trans_alloc_empty(log->l_mp, &tp); > + if (error) > + return error; > + I think we need a big comment explaining the use of this transaction here. Except for that and any naming issues: Reviewed-by: Christoph Hellwig <hch@xxxxxx> -- To unsubscribe from this list: send the line "unsubscribe linux-xfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html