Re: [PATCH 08/10] xfs_scrub: only retry non-permanent repair failures

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Jul 25, 2018 at 06:16:15PM -0700, Eric Sandeen wrote:
> On 6/26/18 7:48 PM, Darrick J. Wong wrote:
> > From: Darrick J. Wong <darrick.wong@xxxxxxxxxx>
> > 
> > If a repair fails, we want to retry the repair if the error was a
> > transient one, such as ENOMEM.  For "permanent" ones (shutdown fs,
> > repair not supported by kernel, readonly fs) there's no point to
> > retrying them so just error out immediately.
> > 
> > Signed-off-by: Darrick J. Wong <darrick.wong@xxxxxxxxxx>
> 
> Is there something that stops infinite retries?
> (I need to get this all applied for context I guess)

If scrub notices the set of unrepaired things stops shrinking it'll try
them all again single-threaded and complain about anything that didn't
get fixed.

--D

> But anyway,
> Reviewed-by: Eric Sandeen <sandeen@xxxxxxxxxx>
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-xfs" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-xfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [XFS Filesystem Development (older mail)]     [Linux Filesystem Development]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux RAID]     [Linux SCSI]


  Powered by Linux