On 6/22/18 1:44 AM, Kazuya Mio wrote:
> To set/check/clear a project quota, xfs_quota performs a pre-order tree
> traversal by using nftw(3). The documentation states that the -d option
> can be used to skip subtrees below a certain level in the directory
> hierarchy. Unfortunately, {check,setup,clear}_project returns -1 when
> DEPTH is hit, which stops the directory tree walk immediately. We only
> wanted to skip the subtree, so return 0 instead.
>
> Signed-off-by: Kazuya Mio <k-mio@xxxxxxxxxxxxx>
> Reviewed-by: Carlos Maiolino <cmaiolino@xxxxxxxxxx>
Getting this merged now, but an xfstests would be really, really good
to validate this behavior. (hint, hint).
Thanks,
-Eric
> ---
> quota/project.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
> diff --git a/quota/project.c b/quota/project.c
> index e4e7a01..20bc01b 100644
> --- a/quota/project.c
> +++ b/quota/project.c
> @@ -101,7 +101,7 @@ check_project(
> int fd;
>
> if (recurse_depth >= 0 && data->level > recurse_depth)
> - return -1;
> + return 0;
>
> if (flag == FTW_NS ){
> exitcode = 1;
> @@ -146,7 +146,7 @@ clear_project(
> int fd;
>
> if (recurse_depth >= 0 && data->level > recurse_depth)
> - return -1;
> + return 0;
>
> if (flag == FTW_NS ){
> exitcode = 1;
> @@ -193,7 +193,7 @@ setup_project(
> int fd;
>
> if (recurse_depth >= 0 && data->level > recurse_depth)
> - return -1;
> + return 0;
>
> if (flag == FTW_NS ){
> exitcode = 1;
>
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-xfs" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
--
To unsubscribe from this list: send the line "unsubscribe linux-xfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
