On 7/23/18 9:35 PM, Eric Sandeen wrote: > On 7/23/18 7:34 PM, Eric Sandeen wrote: >> xfs_repair checks allocated but unused (free) inodes in on-disk clusters, >> and up until now silently repairs any errors, and as a result does not >> alter exit status if errors are found. >> >> The in-kernel verifiers will be noisy about these errors and instruct >> the user to run repair, so it's best if repair is explicit about any >> fixes it makes as a result. >> >> To ensure we catch anything the kernel would complain about, re-use >> xfs_dinode_verify to determine whether we must clear a free inode. >> >> Note, however, that the verifier contains only a subset of the checks >> currently in clear_dinode. This should be ok; if it's not, the checks >> should be added to the verifier in any case. >> >> Signed-off-by: Eric Sandeen <sandeen@xxxxxxxxxx> > Ugh, dammit, pulled the trigger too soon, tests were looking fine until > the last few. Need to look at this more. With the free inode extent validator fix I sent earlier today I think it's safe to resume normal review activities for these 2 patches. :) Thanks, -Eric -- To unsubscribe from this list: send the line "unsubscribe linux-xfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
