On Fri, Jul 20, 2018 at 09:05:50AM -0700, Christoph Hellwig wrote: > On Thu, Jul 19, 2018 at 04:31:20PM -0400, Brian Foster wrote: > > On Thu, Jul 19, 2018 at 12:47:59PM -0700, Christoph Hellwig wrote: > > > On Thu, Jul 19, 2018 at 12:18:26PM -0400, Brian Foster wrote: > > > > FYI, this accidentally leaves off libxfs/xfs_rtbitmap.c, which also > > > > requires the xfs_defer.h include treatment. > > > > > > I wonder if we shouldn't just move struct xfs_defer_ops to xfs_trans.h > > > instead. > > > > I thought about doing that, was curious how many files I'd have to > > modify and ended up just plowing through them all. :P I'm happy to move > > the struct def over if nobody objects. > > To me moving it feels like the right thing. In the end xfs_trans will be > the prime user of xfs_defer_ops, assuming we even keep it as a separate > structure at all. I don't have a problem with moving it either, but if you do please make sure it ports to xfsprogs (it probably will without much fuss). --D > -- > To unsubscribe from this list: send the line "unsubscribe linux-xfs" in > the body of a message to majordomo@xxxxxxxxxxxxxxx > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-xfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
